-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resource access checks in getResource and getResourceAsStream #3229
Conversation
Fixes #3136 |
26a2f23
to
ed6e6f3
Compare
Code updated and personal build running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from the nitpick on spacing, I'm OK with this
Allow getResource et al. to search the current module if the package in question is accessible by the caller's module. [ci skip] Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
ed6e6f3
to
2ea3eed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Jenkins test sanity plinux jdk8,11 |
Jenkins test extended xlinux jdk10 |
Jenkins test sanity plinux jdk8,jdk11 |
@DanHeidinga all tests passed. |
Allow getResource et al. to search the current module if the package in
question is accessible by the caller's module.
Fixes #3136
Signed-off-by: Peter Bain peter_bain@ca.ibm.com