Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource access checks in getResource and getResourceAsStream #3229

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

pdbain-ibm
Copy link
Contributor

@pdbain-ibm pdbain-ibm commented Oct 11, 2018

Allow getResource et al. to search the current module if the package in
question is accessible by the caller's module.

Fixes #3136

Signed-off-by: Peter Bain peter_bain@ca.ibm.com

@pdbain-ibm
Copy link
Contributor Author

Fixes #3136

@pdbain-ibm
Copy link
Contributor Author

Code updated and personal build running.

@pdbain-ibm pdbain-ibm changed the title WIP Fix resource access checks in getResource and getResourceAsStream Fix resource access checks in getResource and getResourceAsStream Oct 11, 2018
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the nitpick on spacing, I'm OK with this

Allow getResource et al. to search the current module if the package in
question is accessible by the caller's module.

[ci skip]

Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga DanHeidinga self-assigned this Oct 12, 2018
@DanHeidinga
Copy link
Member

Jenkins test sanity plinux jdk8,11

@DanHeidinga
Copy link
Member

Jenkins test extended xlinux jdk10

@DanHeidinga
Copy link
Member

Jenkins test sanity plinux jdk8,jdk11

@pdbain-ibm
Copy link
Contributor Author

@DanHeidinga all tests passed.

@DanHeidinga DanHeidinga merged commit 3acd9df into eclipse-openj9:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants