Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Fix FFI on osx #3214

Merged
merged 1 commit into from
Oct 11, 2018
Merged

CMake: Fix FFI on osx #3214

merged 1 commit into from
Oct 11, 2018

Conversation

dnakamura
Copy link
Contributor

x86/unix64.S should only be built on linux

Signed-off-by: Devin Nakamura devinn@ca.ibm.com

x86/unix64.S should only be built on linux

Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as this only effects cmake

@DanHeidinga
Copy link
Member

Assuming the travis build passes, this is ok to merge

@DanHeidinga DanHeidinga self-assigned this Oct 10, 2018
@DanHeidinga DanHeidinga merged commit 97f5820 into eclipse-openj9:master Oct 11, 2018
@dnakamura dnakamura deleted the ffi_fix branch October 15, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants