Add Java11 JPP tag to ConstantDynamic methods #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConstantDynamic methods are only available for Java 11 Signed-off-by: Jason Feng <fengj@ca.ibm.com>
|
jenkins test sanity zlinux jdk11 |
pshipton
approved these changes
Oct 10, 2018
|
This appears to have broken at least the jdk8 builds, #3204. I'm going to revert it while we figure it out. |
|
One theory is there is something in the vm constant pool that needs to be conditional. |
|
Looking at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Java11 JPPtag toConstantDynamicmethodsConstantDynamicmethods are only available forJava 11Verified manually that
pConfig Java 8/9/1011/12still compile.Note: also noticed that there are significant code duplication between
resolveConstantDynamicandresolveInvokeDynamic, leave refactoring to another PR instead.closes: #2986
Reviewer: @DanHeidinga
Signed-off-by: Jason Feng fengj@ca.ibm.com