fix invalid assertion check in test #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
approved these changes
Oct 10, 2018
smlambert
reviewed
Oct 10, 2018
| @@ -833,7 +833,8 @@ public void testMemoryPoolMXBeanProxy() { | |||
| MemoryUsage directUsage = realBean.getCollectionUsage(); | |||
| validateMemoryUsage(proxyUsage); | |||
| validateMemoryUsage(directUsage); | |||
| AssertJUnit.assertEquals(directUsage, proxyUsage); | |||
| /* directUsage and proxyUsage could be different, if gc happened between getCollectionUsage() calls*/ | |||
| // AssertJUnit.assertEquals(directUsage, proxyUsage); | |||
|
|
|||
There was a problem hiding this comment.
Are you keeping it in the code as a comment to come back to it? If it is invalid, do you not simply want to remove it?
There was a problem hiding this comment.
removed the assertion check and leave comment for a reminder
- collection Usage of the same memoryPool might be different between getCollectionUsage() calls. Signed-off-by: Lin Hu <linhu@ca.ibm.com>
smlambert
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lin Hu linhu@ca.ibm.com