Enable openssl within nightly and pr builds #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdekonin
force-pushed
the
master
branch
2 times, most recently
from
33a2902 to
bcb6893
Compare
pshipton
reviewed
Oct 5, 2018
| @@ -279,11 +287,7 @@ linux_x86-64: | |||
| 11: 'hw.arch.x86 && sw.os.ubuntu' | |||
| next: 'hw.arch.x86 && sw.os.ubuntu' | |||
| extra_configure_options: | |||
| 8: '--with-noncompressedrefs' | |||
| 9: '--with-noncompressedrefs' | |||
There was a problem hiding this comment.
No I did not. Restored.
buildenv/jenkins/common/build
Outdated
| @@ -81,7 +81,7 @@ def get_sources() { | |||
| checkout_pullrequest() | |||
| } else { | |||
| sh "git checkout ${OPENJDK_SHA}" | |||
| sh "bash ./get_source.sh ${OPENJ9_REPO_OPTION} ${OPENJ9_BRANCH_OPTION} ${OPENJ9_SHA_OPTION} ${OMR_REPO_OPTION} ${OMR_BRANCH_OPTION} ${OMR_SHA_OPTION}" | |||
| sh "bash ./get_source.sh $EXTRA_GETSOURCE_OPTIONS ${OPENJ9_REPO_OPTION} ${OPENJ9_BRANCH_OPTION} ${OPENJ9_SHA_OPTION} ${OMR_REPO_OPTION} ${OMR_BRANCH_OPTION} ${OMR_SHA_OPTION}" | |||
There was a problem hiding this comment.
Should $EXTRA_GETSOURCE_OPTIONS be ${EXTRA_GETSOURCE_OPTIONS} ?
There was a problem hiding this comment.
Sure, should be consistent.
|
This change doesn't address I expect |
* [skip ci] * Addresses eclipse-openj9#3118 * all platforms; windows 32/64, xlinux, xlinux large heap, plinux, zlinux, aix * JDK8 only Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
pshipton
approved these changes
Oct 5, 2018
|
Reverting as the changes are causing build failures i.e. https://ci.eclipse.org/openj9/job/PullRequest-Compile-JDK8-linux_390-64_cmprssptrs-OpenJ9/43/console |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joe deKoning joe_dekoning@ca.ibm.com
fyi @pshipton