Fix jit crash in Symbol staticName #3155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caller of Symbol::staticName typically assumes the underlying symbol represents a static field. However, the condition that guards the call currently only checks for a staic symbol, which is insufficient as other types like Constant Dynamic. Method Handle, Method Type all use static symbols. Use the correct check Symbol::isStaticField which precludes the above mentioned non-static field types. Signed-off-by: Yan Luo <Yan_Luo@ca.ibm.com>
|
Jenkins test sanity xlinux,win jdk8,jdk11 |
2 similar comments
|
Jenkins test sanity xlinux,win jdk8,jdk11 |
|
Jenkins test sanity xlinux,win jdk8,jdk11 |
|
Jenkins copyright check |
|
Jenkins line endings check |
|
Jenkins test sanity win jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caller of Symbol::staticName typically assumes the underlying symbol
represents a static field. However, the condition that guards the
call currently only checks for a staic symbol, which is insufficient
as other types like Constant Dynamic. Method Handle, Method Type all
use static symbols. Use the correct check Symbol::isStaticField which
precludes the above mentioned non-static field types.
Signed-off-by: Yan Luo Yan_Luo@ca.ibm.com