Add mac osx PLATFORM-oa64 to the jpp config
#3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The line endings check is failing for: |
keithc-ca
reviewed
Oct 3, 2018
jcl/jpp_configuration.xml
Outdated
| @@ -57,7 +57,7 @@ | |||
| <!-- These flags identify the target platform. --> | |||
| <set | |||
| label="platforms" | |||
| flags="PLATFORM-ap64,PLATFORM-mz31,PLATFORM-mz64,PLATFORM-wa64,PLATFORM-xa64,PLATFORM-xi32,PLATFORM-xl64,PLATFORM-xr32,PLATFORM-xs32,PLATFORM-xz31,PLATFORM-xz64"/> | |||
| flags="PLATFORM-ap64,PLATFORM-mz31,PLATFORM-mz64,PLATFORM-wa64,PLATFORM-xa64,PLATFORM-xi32,PLATFORM-xl64,PLATFORM-xr32,PLATFORM-xs32,PLATFORM-xz31,PLATFORM-xz64,PLATFORM-oa64"/> | |||
There was a problem hiding this comment.
The flags were in alphabetical order: could you please retain that property?
Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
DanHeidinga
force-pushed
the
djh/jpp_mac
branch
from
f6fc0cf to
4c17df5
Compare
|
Updated to put |
keithc-ca
approved these changes
Oct 3, 2018
|
jenkins copyright check |
|
jenkins line endings check |
|
We don't need a build for this change; cancelling travis job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in ibmruntimes/openj9-openjdk-jdk8#118 (comment)
issue: #36
Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com