Read Barrier Support for Atomic CAS on X86 #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
0dvictor
force-pushed
the
cas
branch
2 times, most recently
from
2c6b6d3 to
49540a1
Compare
andrewcraik
reviewed
Oct 3, 2018
| @@ -667,7 +667,7 @@ J9::CodeGenerator::lowerTreesPreChildrenVisit(TR::Node *parent, TR::TreeTop *tre | |||
| { | |||
| // J9 | |||
| // | |||
| if (self()->comp()->useCompressedPointers()) | |||
| if (self()->comp()->useCompressedPointers() && !TR::Compiler->target.cpu.isX86()) | |||
There was a problem hiding this comment.
I think this at least deserves a comment - ultimately is the plan for this block of code to die for all code generators?
There was a problem hiding this comment.
Good suggestion, done.
|
Jenkins test sanity xlinux,win jdk8,jdk11 |
andrewcraik
reviewed
Oct 3, 2018
| if(node->isSafeForCGToFastPathUnsafeCall()) | ||
| return inlineCompareAndSwapNative(node, (TR::Compiler->target.is64Bit() && !comp->useCompressedPointers()) ? 8 : 4, true, cg); | ||
| if (UseOldCompareAndSwapObject) |
There was a problem hiding this comment.
these two if blocks need {}s
Updated inlinig logic of atomic compare and swap so that a read barrier can be inserted where necessary. Signed-off-by: Victor Ding <dvictor@ca.ibm.com>
|
Jenkins test sanity xlinux,win jdk8,jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated inlinig logic of atomic compare and swap so that a read barrier can be inserted where necessary.
Part of Issue #3054
Signed-off-by: Victor Ding dvictor@ca.ibm.com