Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverted FSD test in DTFJ #3109

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Conversation

gacholio
Copy link
Contributor

@gacholio gacholio commented Oct 2, 2018

The logic for determining if FSD is enabled is backwards.

[ci skip]

Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com

The logic for determining if FSD is enabled is backwards.

[ci skip]

Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
@gacholio gacholio requested a review from DanHeidinga October 2, 2018 23:44
@gacholio
Copy link
Contributor Author

gacholio commented Oct 2, 2018

This really doesn't require even basic testing. It's a single-character change that's obviously correct syntax, and the feature itself is not tested.

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga DanHeidinga self-assigned this Oct 3, 2018
@DanHeidinga
Copy link
Member

Merging without a build as it's obviously correct

@DanHeidinga DanHeidinga merged commit eb4a37d into eclipse-openj9:master Oct 3, 2018
@gacholio gacholio deleted the fsd branch October 3, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants