Fix failures in Condy Test #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When GC kicks in when constant dynamic object is resolved, VM helper code expects all the registers are stored on Java Stack and while resolving frames it takes this adjustment into account while building frames. Condy Test was failing as it was not storing registers on Java Stack producing corrupted stack frame. Fixes: eclipse-openj9#3082 Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
|
@pshipton @irinarada @fjeremic PR for Condy and asm link fix. |
|
@r30shah why is there an unrelated commit about ASM 7.0 in this PR? |
|
@andrewcraik This asm update is needed as previously we were getting asm-7.0 from snapshot page which gets updated every 10 days or so living us with the broken link. They released 7.0 beta very recently so getting it from release page which is more permanent. |
pshipton
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GC kicks in when constant dynamic object is resolved, VM helper code expects all the registers are stored on Java Stack and while resolving frames it takes this adjustment into account while building frames. Condy Test was failing as it was not storing registers on Java Stack producing corrupted stack frame.
Note this is merged into the v0.10.0-release branch.
Changes originate from #3089 and #3095
Signed-off-by: Rahil Shah rahil@ca.ibm.com