Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java/lang/String.value to isArrayWithConstantElements query #3052

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

fjeremic
Copy link
Contributor

The java/lang/String.value field is a constant which will not change
during the lifetime of the object and hence so are its elements.

Signed-off-by: Filip Jeremic fjeremic@ca.ibm.com

The java/lang/String.value field is a constant which will not change
during the lifetime of the object and hence so are its elements.

Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
@fjeremic
Copy link
Contributor Author

@liqunl could I please get a review?

@fjeremic
Copy link
Contributor Author

Jenkins test sanity xlinux JDK8,JDK11

@liqunl
Copy link
Contributor

liqunl commented Sep 27, 2018

LGTM

@fjeremic
Copy link
Contributor Author

@andrewcraik could I get you to be the commiter for this one?

@andrewcraik andrewcraik self-assigned this Sep 27, 2018
Copy link
Contributor

@andrewcraik andrewcraik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewcraik
Copy link
Contributor

Need CI to finish before merging.

@andrewcraik andrewcraik merged commit 73887f2 into eclipse-openj9:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants