Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map and test -XX:MaxHeapSize and -XX:InitialHeapSize #2996

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Map and test -XX:MaxHeapSize and -XX:InitialHeapSize #2996

merged 2 commits into from
Oct 11, 2018

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Sep 24, 2018 •
edited
Loading

Map -XX:MaxHeapSize= to -Xmx
-XX:InitialHeapSize= to -Xms

Issue #2834
Doc issue eclipse-openj9/openj9-docs#96

@pshipton
Copy link
Member Author

jenkins test sanity zlinux jdk8

@pshipton
Copy link
Member Author

jenkins test sanity zlinux jdk8

@pshipton
Copy link
Member Author

Testing passed

15:14:10 Testing: Verify -XX:MaxHeapSize -XX:InitialHeapSize -XX:ThreadStackSize
15:14:10 Test start time: 2018/09/24 15:14:10 Eastern Standard Time
15:14:10 Running command: "/home/jenkins/jenkins-agent/workspace/PullRequest-Sanity-JDK8-linux_390-64_cmprssptrs-OpenJ9/build/linux-s390x-normal-server-release/images/j2sdk-image/jre/bin/java"  -Xcompressedrefs  -XX:MaxHeapSize=234m -XX:InitialHeapSize=11m -XX:ThreadStackSize=222K -verbose:sizes -version
15:14:10 Time spent starting: 0 milliseconds
15:14:10 Time spent executing: 74 milliseconds
15:14:10 Test result: PASSED

@pshipton pshipton changed the title WIP Map and test -XX:MaxHeapSize, -XX:InitialHeapSize, -XX:ThreadStackSize Map and test -XX:MaxHeapSize, -XX:InitialHeapSize, -XX:ThreadStackSize Sep 24, 2018
@pshipton pshipton mentioned this pull request Sep 24, 2018
Closed
@pshipton pshipton mentioned this pull request Oct 1, 2018
Closed
@pshipton
Copy link
Member Author

pshipton commented Oct 1, 2018 •
edited
Loading

Created #3092 for the travis failure, which seems unrelated to this change.

@pshipton
Copy link
Member Author

pshipton commented Oct 2, 2018

jenkins compile xlinux jdk9

@pshipton
Copy link
Member Author

pshipton commented Oct 2, 2018

jenkins compile xlinux jdk10

@pshipton
Copy link
Member Author

pshipton commented Oct 2, 2018

Wierd errors compiling jdk9+. I will rebase this when I get a chance, and retry the jdk9+ compile

@pshipton
Copy link
Member Author

pshipton commented Oct 4, 2018

jenkins compile xlinux jdk11

@pshipton
Copy link
Member Author

pshipton commented Oct 5, 2018

Rebasing didn't help, I'm guessing implementing -XX:ThreadStackSize is causing the problem. I found the following in the output but not sure if this is where things are going wrong.

checking flags for boot jdk java command for big workloads...  -Xms64M -Xmx1600M -XX:ThreadStackSize=1536
checking flags for bootcycle boot jdk java command for big workloads... -Xms64M -Xmx1600M -XX:ThreadStackSize=1536

@pshipton
Copy link
Member Author

pshipton commented Oct 5, 2018

The -XX:ThreadStackSize value is in KB, i.e. the value specified is multiplied by 1024.

@AdamBrousseau
Copy link
Contributor

Jenkins copyright check

@pshipton pshipton changed the title Map and test -XX:MaxHeapSize, -XX:InitialHeapSize, -XX:ThreadStackSize WIP Map and test -XX:MaxHeapSize, -XX:InitialHeapSize, -XX:ThreadStackSize Oct 10, 2018
@pshipton
Map -XX:MaxHeapSize and -XX:InitialHeapSize
957e1e4 
Map -XX:MaxHeapSize= to -Xmx
-XX:InitialHeapSize= to -Xms

Issue eclipse-openj9#2834

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Add testing for -XX:MaxHeapSize and -XX:InitialHeapSize
136f922 
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton pshipton changed the title WIP Map and test -XX:MaxHeapSize, -XX:InitialHeapSize, -XX:ThreadStackSize WIP Map and test -XX:MaxHeapSize and -XX:InitialHeapSize Oct 10, 2018
@pshipton pshipton changed the title WIP Map and test -XX:MaxHeapSize and -XX:InitialHeapSize Map and test -XX:MaxHeapSize and -XX:InitialHeapSize Oct 10, 2018
@pshipton
Copy link
Member Author

jenkins test sanity zlinux jdk8,jdk11

@pshipton
Copy link
Member Author

@DanHeidinga ready for review

DanHeidinga
DanHeidinga approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga DanHeidinga merged commit 4333a98 into eclipse-openj9:master Oct 11, 2018
@DanHeidinga DanHeidinga added this to the Release 0.11.0 milestone Oct 11, 2018
@pshipton pshipton deleted the mapopt branch March 1, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanHeidinga DanHeidinga DanHeidinga approved these changes

@charliegracie charliegracie charliegracie approved these changes

Assignees
No one assigned
Labels
comp:gc comp:test comp:vm depends:doc
Projects
None yet
Milestone
Release 0.11.0 (Java 8, 11 Oct refresh)
Development

Successfully merging this pull request may close these issues.
4 participants
@pshipton @AdamBrousseau @DanHeidinga @charliegracie