Save local connector address in Attach API code #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Sep 20, 2018
| } | ||
| if (Objects.isNull(addr)) { | ||
| /* startLocalAgent() should have set the property. */ | ||
| return Response.EXCEPTION_AGENT_INITIALIZATION_EXCEPTION + "loadAgentLibrary: " + LOCAL_CONNECTOR_ADDRESS + " not defined"; //$NON-NLS-1$ //$NON-NLS-2$ |
There was a problem hiding this comment.
Needs a space after EXCEPTION_AGENT_INITIALIZATION_EXCEPTION
There was a problem hiding this comment.
This code is the same as that in startLocalAgent(), correct? If so, please factor it out into a separate static method. While you are doing that, please add logging to record the agent address and any errors.
mikezhang1234567890
force-pushed
the
attach
branch
4 times, most recently
from
73756d2 to
8d0dd3f
Compare
mikezhang1234567890
changed the title
pshipton
reviewed
Sep 24, 2018
| try { | ||
| saveLocalConnectorAddress(); | ||
| } catch (IbmAttachOperationFailedException e) { | ||
| return Response.EXCEPTION_AGENT_INITIALIZATION_EXCEPTION + "loadAgentLibrary: " + e.getMessage(); |
There was a problem hiding this comment.
Please add a space between EXCEPTION_AGENT_INITIALIZATION_EXCEPTION and "loadAgentLibrary: "
| try { | ||
| return saveLocalConnectorAddress(); | ||
| } catch (IbmAttachOperationFailedException e) { | ||
| throw new IbmAttachOperationFailedException("startLocalManagementAgent: " + e.getMessage()); |
There was a problem hiding this comment.
This should set the original exception as the cause of the IbmAttachOperationFailedException. Although see the next comment, I think saveLocalConnectorAddress() could just return null.
| IPC.logMessage(LOCAL_CONNECTOR_ADDRESS + " not set"); //$NON-NLS-1$ | ||
| throw new IbmAttachOperationFailedException("startLocalManagementAgent: " + LOCAL_CONNECTOR_ADDRESS + " not defined"); //$NON-NLS-1$ //$NON-NLS-2$ | ||
| throw new IbmAttachOperationFailedException(LOCAL_CONNECTOR_ADDRESS + " not defined"); //$NON-NLS-1$ |
There was a problem hiding this comment.
Does this need to throw an exception? Seems it could just return null.
mikezhang1234567890
force-pushed
the
attach
branch
2 times, most recently
from
e97b67a to
ceb58cb
Compare
|
jenkins test all zlinux jdk8 |
|
At least one failure in extended testing |
VirtualMachine.getAgentProperties() doesn't get the local connector address if it isn't saved to our systems properties. Thus, we check VMSupport class for the local connector address and save it in system properties if it is not there already. Signed-off-by: Mike Zhang <mike.h.zhang@ibm.com>
mikezhang1234567890
force-pushed
the
attach
branch
from
ceb58cb to
a0f34a7
Compare
|
Removed the save local connector code in |
|
jenkins test extended zlinux jdk8 |
pshipton
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #2742, VirtualMachine.getAgentProperties() doesn't get the local connector address if it isn't saved to our systems properties. Thus, we check VMSupport class for the local connector address and save it in system properties if it is not there already.
Fixes #2742
Signed-off-by: Mike Zhang mike.h.zhang@ibm.com