Update CloneWeakReferenceTest for JDK11 #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test sanity xlinux all |
|
Jenkins test sanity xlinux all |
|
Jenkins test sanity xlinux jdk11 |
|
I asked @llxia to update the commit message with some details about the build changes. |
- CloneNotSupportedException is expected for JDK11 - include TestUtilities, so org.openj9.test.util.VersionCheck can be used - testng.jar is needed for TestUtilities - attachAPI has to be excluded due to compilation failure. This will be fixed by eclipse-openj9#2938 [ci skip] Fixes: eclipse-openj9#2801 Signed-off-by: lanxia <lan_xia@ca.ibm.com>
|
Commit message and description are updated. |
pshipton
approved these changes
Sep 19, 2018
|
Thanks for fixing this @llxia . |
|
You are welcome! @pdbain-ibm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used
fixed by Remove dependency on com.ibm.tools.attach.target.AttachHandler in TestUtilities #2938
[ci skip]
Fixes: #2801
Signed-off-by: lanxia lan_xia@ca.ibm.com