-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle printing wide registers #2931
Conversation
} | ||
out.print(" "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a change in behavior, printing 2 spaces between registers when before it was 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Do you think the extra space is helpful? Do you imagine anyone is decomposing the output by character columns? I considered how we might reduce the output to two registers per line when they're wider than 64 bits, but didn't arrive at a happy solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any change is at risk of breaking something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing reverted to 3.
jenkins test sanity zlinux jdk8 |
Set as WIP while more internal testing is done. |
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
jdk8 sanity testing passed |
840dc22
to
d2f35c7
Compare
jdmpview should not truncate registers when displaying them in commands such as 'info thread'.
Fixes #2928