Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle printing wide registers #2931

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Conversation

keithc-ca
Copy link
Contributor

jdmpview should not truncate registers when displaying them in commands such as 'info thread'.

Fixes #2928

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
}
out.print(" ");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a change in behavior, printing 2 spaces between registers when before it was 3.

Copy link
Contributor Author

@keithc-ca keithc-ca Sep 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Do you think the extra space is helpful? Do you imagine anyone is decomposing the output by character columns? I considered how we might reduce the output to two registers per line when they're wider than 64 bits, but didn't arrive at a happy solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any change is at risk of breaking something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing reverted to 3.

@pshipton
Copy link
Member

jenkins test sanity zlinux jdk8

@pshipton pshipton changed the title Handle printing wide registers WIP Handle printing wide registers Sep 20, 2018
@pshipton
Copy link
Member

Set as WIP while more internal testing is done.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@pshipton
Copy link
Member

@pshipton pshipton changed the title WIP Handle printing wide registers Handle printing wide registers Sep 20, 2018
@pshipton pshipton merged commit 3557a20 into eclipse-openj9:master Sep 20, 2018
@keithc-ca keithc-ca deleted the registers branch September 20, 2018 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants