Temporarily support both JAVA_IMPL and JDK_IMPL #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewer: @llxia |
llxia
reviewed
Sep 19, 2018
test/TestConfig/settings.mk
Outdated
| @@ -257,6 +265,7 @@ setup_%: | |||
| $(ECHO) There are $(TOTALCOUNT) test targets in $(TESTTARGET).; \ | |||
| fi | |||
| $(JAVA_COMMAND) -version | |||
| $(CMD) | |||
- Convert JAVA_IMPL to JDK_IMPL if JAVA_IMPL is defined - Change JAVA_IMPL in playlist.xml to JDK_IMPL [ci skip] Signed-off-by: Renfei Wang <renfeiw@ca.ibm.com>
|
Jenkins test sanity plinux all |
|
I'm guessing we will need to check all the test jobs are using |
|
yes, just a heads up for now, Jenkins file in AdoptOpenJDK needs to be updated to use JDK_IMPL and JDK_VERSION. Maybe support both for the time being. |
3 tasks
llxia
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip]
Signed-off-by: Renfei Wang renfeiw@ca.ibm.com