Update MethodHandle lookup for Nestmates #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gacholio Can you take a look at this? |
|
Seems reasonable to me. @DanHeidinga would you prefer the runtime check over the ifdef? |
fengxue-IS
changed the title
Yes, we've tried to keep the code under runtime time checks whenever possible so this should behave the same way. We may want to revisit that in the future but for now, I'd prefer consistency - especially when it's not in perf sensitive parts of the code. |
gacholio
reviewed
Sep 18, 2018
- Nestmates allow invokeInterface to target private interface methods Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
fengxue-IS
force-pushed
the
nestmatesMH
branch
from
dfa1c32 to
6c686f6
Compare
|
@DanHeidinga @gacholio any further concerns? This appears ready for re-review. |
|
Jenkins test sanity plinux jdk8,jdk11 |
|
Once the build passes, I'm fine with whoever sees it first to merge it. |
gacholio
approved these changes
Sep 19, 2018
|
The CloneNotSupportedException failure is expected, otherwise the jdk11 testing looks good on zlinux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jack Lu Jack.S.Lu@ibm.com