Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lithuanian tests to conform to Unicode 10 for Java 11 #2895

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

fjeremic
Copy link
Contributor

According to #1875 the Unicode 10 will be used for Java 11. We must
update our Lithuanian tests with the new codepoints as per [1].

[1] https://www.unicode.org/Public/10.0.0/ucd/extracted/DerivedCombiningClass.txt

Fixes: #2890

Signed-off-by: Filip Jeremic fjeremic@ca.ibm.com

@fjeremic
Copy link
Contributor Author

Leaving as WIP until I've done some testing. Feel free to review.

@fjeremic
Copy link
Contributor Author

Jenkins test sanity xlinux JDK11

@fjeremic fjeremic requested a review from pshipton September 17, 2018 16:36
@fjeremic
Copy link
Contributor Author

I don't see the failure in the Sanity builds, but the build doesn't succeed because of other issues. I'm currently compiling my own JDK11 in a Docker image to validate the test_toLowerCase_lithuanian test failure and that the new fix to the test will make it pass. Will have this done by sometime tomorrow.

@pshipton
Copy link
Member

jenkins test sanity aix jdk8,jdk10

@pshipton
Copy link
Member

@fjeremic the fact that JCL_Test_0 passed should be good enough. Once jdk8 and jdk10 pass I'm happy to merge.

@pshipton
Copy link
Member

Although there is a blocking problem atm for building OpenJ9, unrelated to this change.

@andrewcraik
Copy link
Contributor

@pshipton the blocking failure was fixed by the merge of #2649.

@fjeremic
Copy link
Contributor Author

Jenkins test sanity aix jdk8,jdk10

@fjeremic fjeremic changed the title WIP: Update Lithuanian tests to conform to Unicode 10 for Java 11 Update Lithuanian tests to conform to Unicode 10 for Java 11 Sep 17, 2018
@pshipton
Copy link
Member

@andrewcraik doesn't seem fixed, or there is another problem.
"/home/u0020236/workspace/PullRequest-Sanity-JDK8-aix_ppc-64_cmprssptrs-OpenJ9/build/aix-ppc64-normal-server-release/vm/compiler/../compiler/codegen/CodeGenGPU.cpp", line 1314.1: 1540-5220 (S) "Number of elements in nvvmOpCodeNames does not match the value of TR::NumIlOps"

@fjeremic
Copy link
Contributor Author

@andrewcraik doesn't seem fixed, or there is another problem.

I forgot to rebase after the fix in OpenJ9 was merged. Will do this first thing in the morning. Don't have my SSH key setup at home unfortunately.

According to eclipse-openj9#1875 the Unicode 10 will be used for Java 11. We must
update our Lithuanian tests with the new codepoints as per [1].

[1] https://www.unicode.org/Public/10.0.0/ucd/extracted/DerivedCombiningClass.txt

Fixes: eclipse-openj9#2890

Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
@fjeremic fjeremic force-pushed the fix-unicode10-java11-test branch from cc97d47 to 452ae15 Compare September 18, 2018 14:46
@fjeremic
Copy link
Contributor Author

Jenkins test sanity aix jdk8,jdk10

@pshipton
Copy link
Member

Jenkins test sanity aix jdk8,jdk10

@fjeremic
Copy link
Contributor Author

fjeremic commented Sep 18, 2018

Looks like we have some infrastructure problems.

https://openj9.slack.com/archives/C8312LCV9/p1537284230000100

@pshipton
Copy link
Member

I give up on the PR testing. The change looks good, should not affect 8/9/10, and worked on jdk11. I'm just going to merge it and if it causes problems we can deal with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants