-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lithuanian tests to conform to Unicode 10 for Java 11 #2895
Update Lithuanian tests to conform to Unicode 10 for Java 11 #2895
Conversation
Leaving as WIP until I've done some testing. Feel free to review. |
Jenkins test sanity xlinux JDK11 |
I don't see the failure in the Sanity builds, but the build doesn't succeed because of other issues. I'm currently compiling my own JDK11 in a Docker image to validate the |
jenkins test sanity aix jdk8,jdk10 |
@fjeremic the fact that JCL_Test_0 passed should be good enough. Once jdk8 and jdk10 pass I'm happy to merge. |
Although there is a blocking problem atm for building OpenJ9, unrelated to this change. |
Jenkins test sanity aix jdk8,jdk10 |
@andrewcraik doesn't seem fixed, or there is another problem. |
I forgot to rebase after the fix in OpenJ9 was merged. Will do this first thing in the morning. Don't have my SSH key setup at home unfortunately. |
According to eclipse-openj9#1875 the Unicode 10 will be used for Java 11. We must update our Lithuanian tests with the new codepoints as per [1]. [1] https://www.unicode.org/Public/10.0.0/ucd/extracted/DerivedCombiningClass.txt Fixes: eclipse-openj9#2890 Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
cc97d47
to
452ae15
Compare
Jenkins test sanity aix jdk8,jdk10 |
Jenkins test sanity aix jdk8,jdk10 |
Looks like we have some infrastructure problems. https://openj9.slack.com/archives/C8312LCV9/p1537284230000100 |
I give up on the PR testing. The change looks good, should not affect 8/9/10, and worked on jdk11. I'm just going to merge it and if it causes problems we can deal with it. |
According to #1875 the Unicode 10 will be used for Java 11. We must
update our Lithuanian tests with the new codepoints as per [1].
[1] https://www.unicode.org/Public/10.0.0/ucd/extracted/DerivedCombiningClass.txt
Fixes: #2890
Signed-off-by: Filip Jeremic fjeremic@ca.ibm.com