Adjust use of internal methods in String.lines() #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
Please specify close:issue# such that others can see this WIP PR for that issue, thanks. |
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
jenkins compile zlinux jdk11 |
|
Seems building java 11 is failing for other reasons atm. |
|
jenkins compile zlinux jdk11 |
1 similar comment
|
jenkins compile zlinux jdk11 |
pshipton
approved these changes
Sep 18, 2018
|
The jdk11 build is failing for other reasons, but the change looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the head stream of openjdk, the support methods in
StringLatin1andStringUTF16used byString.lines()require two more arguments.Fixes #2886