Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold static final fields of type VarHandle under Xaggressive #2884

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

liqunl
Copy link
Contributor

@liqunl liqunl commented Sep 17, 2018

Create known object index for static final fields that are instances of
VarHandle in ILGen under Xaggressive such that VarHandle calls can
be targeted inlined.

Signed-off-by: Liqun Liu liqunl@ca.ibm.com

@liqunl liqunl changed the title WIP: Fold static final fields of type VarHandle under aggressive opts WIP: Fold static final fields of type VarHandle under Xaggressive Sep 17, 2018
@liqunl liqunl changed the title WIP: Fold static final fields of type VarHandle under Xaggressive Fold static final fields of type VarHandle under Xaggressive Sep 17, 2018
@liqunl
Copy link
Contributor Author

liqunl commented Sep 17, 2018

Remove WIP since the pbuild has passed.

Copy link
Contributor

@andrewcraik andrewcraik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewcraik
Copy link
Contributor

Jenkins test sanity xlinux,win jdk8,jdk11

Create known object index for static final fields that are instances of
VarHandle in ILGen under Xaggressive such that VarHandle calls can
be targeted inlined.

Signed-off-by: Liqun Liu <liqunl@ca.ibm.com>
@liqunl
Copy link
Contributor Author

liqunl commented Sep 18, 2018

Rebased the branch to pick #2649. @fjeremic Can I ask for a help in launching the jenkins sanity test since Andrew's offline now?

@fjeremic
Copy link
Contributor

Jenkins test sanity all JDK8

@andrewcraik
Copy link
Contributor

sanity looks good - travis is currently running so I'll give that longer before merging.

@andrewcraik
Copy link
Contributor

All good - will merge this now

@andrewcraik andrewcraik merged commit 06d6d78 into eclipse-openj9:master Sep 18, 2018
@liqunl liqunl deleted the xaggressive branch January 24, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants