Fix Bug with Condy Primitive Long and Double #2878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While generating IL for byte code "ldc2lw" and "ldc2dw" we were assuming the constant is long and double type respectively. This is not true in case of Constant Dynamic where these primitives are boxed into corresponding object and we need to take special steps for generating appropriate IL. Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
|
@fjeremic @andrewcraik @yanluo7 This is the fix needed for JIT to identify correct type for primitive long and double condy |
|
LGTM. |
fjeremic
approved these changes
Sep 14, 2018
|
Jenkins test sanity xlinux,plinux,zlinux JDK11 |
|
LGTM from me - I'll let @fjeremic marshal it through |
|
JDK11 failures due to #2708. This was way before we merged any of the JIT changes in this area so it cannot be related to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While generating IL for byte code "ldc2lw" and "ldc2dw" we were assuming the constant is long and double type respectively. This is not true in case of Constant Dynamic where these primitives are boxed into corresponding object and we need to take special steps for generating appropriate IL.
Signed-off-by: Rahil Shah rahil@ca.ibm.com