Improve condy PicBuilder sequence #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in [1] we can use a better instruction sequence in our condy resolution function. [1] eclipse-openj9#2806 (comment) Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
|
As an aside there is no doubt a lot of the instruction sequences in PicBuilder can be improved greatly. i.e. similar patching logic happens for normal field resolution and we use an |
|
LGTM. I agree with @fjeremic . I think even in the sequences we needed, so many instances where we can reduce number of instructions by choosing better ones. Like we did for condy. |
|
Jenkins test sanity zlinux JDK8,JDK11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in [1] we can use a better instruction sequence in our
condy resolution function.
[1] #2806 (comment)
Signed-off-by: Filip Jeremic fjeremic@ca.ibm.com