Add constant dynamic slot iterator #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrowthe
changed the title
acrowthe
force-pushed
the
add_constant_dynamic_slot_iterator
branch
from
952101c to
74e9b5c
Compare
acrowthe
force-pushed
the
add_constant_dynamic_slot_iterator
branch
from
74e9b5c to
a752274
Compare
acrowthe
force-pushed
the
add_constant_dynamic_slot_iterator
branch
25 times, most recently
from
8de5693 to
a1d0102
Compare
tajila
reviewed
Sep 21, 2018
test/functional/TestUtilities/src/org/openj9/test/util/CircularBuffer.java
Outdated
Show resolved
Hide resolved
acrowthe
force-pushed
the
add_constant_dynamic_slot_iterator
branch
from
3ab83f1 to
78a0264
Compare
acrowthe
commented
Sep 21, 2018
test/functional/Java11andUp/src/org/openj9/test/condy/GarbageCollectionCondyTest.java
Outdated
Show resolved
Hide resolved
acrowthe
force-pushed
the
add_constant_dynamic_slot_iterator
branch
4 times, most recently
from
3f3292e to
f4cdd72
Compare
tajila
reviewed
Sep 25, 2018
test/functional/Java11andUp/src/org/openj9/test/condy/DefineCondyClass.java
Outdated
Show resolved
Hide resolved
test/functional/Java11andUp/src/org/openj9/test/condy/GarbageCollectionCondyTest.java
Outdated
Show resolved
Hide resolved
acrowthe
force-pushed
the
add_constant_dynamic_slot_iterator
branch
2 times, most recently
from
b7d3088 to
6f1cf9f
Compare
tajila
approved these changes
Sep 25, 2018
|
@dmitripivkine please take another look |
|
Jenkins test sanity xLinux jdk8 |
|
Jenkins test sanity pLinux jdk11 |
|
Failure: -Xgcpolicy metronome is not supported at all platforms |
|
Add WIP: to prevent accidental merge. Test for -Xgcpolicy:metronome should be requested at supported platforms only |
acrowthe
changed the title
tajila
reviewed
Sep 26, 2018
acrowthe
force-pushed
the
add_constant_dynamic_slot_iterator
branch
from
6f1cf9f to
4ff8db7
Compare
|
@dmitripivkine can you please re-run the jdk11 sanity test |
|
Jenkins test sanity pLinux jdk11 |
|
Jenkins test sanity xLinux jdk11 |
Implementing ConstantDynamicSlotIterator: - Implements scanNow() functionality for ConstantDynamic pool entries - Refactors scanCondySlot out of ConstantPoolObjectSlotIterator - Simplifies ConstantPoolObjectSlotIterator by acting as sub iterator - Handles the requirement to scan constant dynamics multiple times Implementing tests: - Test garbage collection on constant dynamics that have null, primitive and exception values. Signed-off-by: Andrew Crowther <acrowthe3388@gmail.com>
acrowthe
force-pushed
the
add_constant_dynamic_slot_iterator
branch
from
4ff8db7 to
e87d063
Compare
|
Jenkins test sanity pLinux jdk11 |
|
Jenkins test sanity xLinux jdk11 |
pshipton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move constant dynamic scanning from ConstantPoolObjectSlotIterator into a separate class to reduce complexity.