Implement java.lang.Access.invalidatePackageAccessCache() and cleanup #2854
Conversation
|
The PR and commit title is a little misleading, please change it to something like "Implement java.lang.Access.invalidatePackageAccessCache() and cleanup". |
| @@ -232,8 +232,6 @@ public ServicesCatalog createOrGetServicesCatalog(ClassLoader classLoader) { | |||
| return classLoader.createOrGetServicesCatalog(); | |||
| } | |||
|
|
|||
| /* removed in build 160 */ | |||
| @Deprecated | |||
| public ServicesCatalog getServicesCatalog(ClassLoader classLoader) { | |||
There was a problem hiding this comment.
I think this API is actually unused in the latest? As only getServicesCatalog(ModuleLayer) is used.
pdbain-ibm
changed the title
pdbain-ibm
force-pushed
the
cleanup
branch
2 times, most recently
from
862db37 to
77fe252
Compare
|
Title changed and getServicesCatalog(ClassLoader classLoader) removed. |
|
Hmm, I wasn't saying that getServicesCatalog(ClassLoader classLoader) isn't used anywhere, just that it isn't used in the latest and should remain deprecated. |
|
The title of the commit itself was not changed. |
or use preprocessor tags to remove it from later releases. |
|
getServicesCatalog() isn't used in Java 8, 10, or 11. It might be used in Java 9 B148, so I will JPP it out. |
Remove misleading comments and annotations about obsolete methods. Implement invalidatePackageAccessCache(). Remove getServicesCatalog(ClassLoader classLoader) from Java 10 and later. Fixes eclipse-openj9#2234. Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
|
Commit comment updated, preprocessor directive added. |
|
jenkins test sanity zlinux jdk10 |
Remove incorrect comments and annotations about obsolete methods.
Implement invalidatePackageAccessCache().
Fixes #2234.
Signed-off-by: Peter Bain peter_bain@ca.ibm.com