Dispatch direct (private) calls in x86 PicBuilder #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In x86 PicBuilder, handle J9TR_J9_VTABLE_INDEX_DIRECT_METHOD_FLAG for virtual calls and J9TR_J9_ITABLE_OFFSET_DIRECT for interface calls as required for nestmates unresolved private invoke (eclipse-openj9#2673). Signed-off-by: Devin Papineau <devinmp@ca.ibm.com>
jdmpapin
force-pushed
the
nest-priv-invoke
branch
from
52e656c to
bada7c8
Compare
This was referenced Sep 14, 2018
|
@andrewcraik @0dvictor Would you mind reviewing? This is required for jdk11 (nestmates) to work properly |
|
Jenkins test sanity xlinux,win,win32 jdk11 |
|
@irinarada FYI |
|
The sanity failures look unrelated to this change. |
|
LGTM - given that there is a second review that looks good and the sanity failures are unrelated I am going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In x86 PicBuilder, handle J9TR_J9_VTABLE_INDEX_DIRECT_METHOD_FLAG for
virtual calls and J9TR_J9_ITABLE_OFFSET_DIRECT for interface calls as
required for nestmates unresolved private invoke (#2673).