Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for valid Constant_Dynamic name and signature #2842

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

fengxue-IS
Copy link
Contributor

  • add Constant_Dynamic to class format check in static verification

Signed-off-by: Jack Lu Jack.S.Lu@ibm.com

- add Constant_Dynamic to class format check in static verification

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
@fengxue-IS
Copy link
Contributor Author

@ChengJin01 can you take a look?

@fengxue-IS
Copy link
Contributor Author

Senior Review: @DanHeidinga please take a look, thanks

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga
Copy link
Member

Jenkins test sanity xlinux jdk11
(The travis build was sufficient to see a basic compile pass)

@DanHeidinga DanHeidinga self-assigned this Sep 13, 2018
@DanHeidinga
Copy link
Member

Jenkins test sanity xlinux jdk11

@DanHeidinga DanHeidinga merged commit e8ecf38 into eclipse-openj9:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants