Change .i macro annotations to not use @, pt. 2 #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the OMR change to ddrgen to not annotate source files with the @ symbol, we can now simplify the sed command to only match the new pattern. Signed-off-by: Mike Zhang <mike.h.zhang@ibm.com>
|
@keithc-ca can you please review? |
keithc-ca
approved these changes
Sep 12, 2018
|
Jenkins test sanity xlinux jdk8,jdk10 |
keithc-ca
added a commit
to keithc-ca/openj9
that referenced
this pull request
Dec 6, 2018
* core files created by JVMs that don't include eclipse/omr/eclipse-openj9#2830 may describe fields with standard C type expresions which could prevent dynamic generation of the pointer class * e.g. map 'short' to TYPE_I16 rather than returning TYPE_UNKNOWN Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With eclipse-omr/omr#2929, the change to ddrgen to not annotate source files with the @ symbol merged, we can now simplify the sed command to only match the new pattern.
Signed-off-by: Mike Zhang mike.h.zhang@ibm.com