Implement constant dynamic support in Power codegen #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjeremic
reviewed
Sep 7, 2018
| #else | ||
| rlwinm r3, r3, 0, 0xfffffffe ! <clinit> clear up the last bit, which must be zero | ||
| #endif | ||
| cmpi cr0, 0, r17, in_clinit ! <clinit> is being executed |
There was a problem hiding this comment.
Indentations look quite odd with the tabs.
There was a problem hiding this comment.
Looks like all this weird indentation crept in from code that was copied from _interpreterUnresolvedStringGlue. I'll go ahead and clean it up a little bit...
There was a problem hiding this comment.
I've replaced all the tabs with spaces for now. I'm still not a big fan of the indentation, but I'm trying to keep it consistent with what's used in the other PicBuilder helpers.
aviansie-ben
force-pushed
the
constantdynamic-power
branch
from
c9f14ae to
0b6fc82
Compare
This commit adds the necessary code to the Power code generator to support resolving unresolved constant dynamic constant pool entries in JITted code. Signed-off-by: Ben Thomas <ben@benthomas.ca>
aviansie-ben
force-pushed
the
constantdynamic-power
branch
from
0b6fc82 to
bb012f5
Compare
|
Jenkins line endings check |
gita-omr
approved these changes
Sep 12, 2018
aviansie-ben
changed the title
|
@gita-omr since eclipse-omr/omr#2946 has been merged, this should be ready to merge now |
fjeremic
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the necessary code to the Power code generator to
support resolving unresolved constant dynamic constant pool entries in
JITted code.
Signed-off-by: Ben Thomas ben@benthomas.ca
This PR depends on eclipse-omr/omr#2946.