Handle string conversion errors in attach API #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the name of the temporary directory cannot be converted to UTF-16, use the Java system property. Fixes eclipse-openj9#2781 Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
|
@pshipton would you kindly review? |
CodingFabian
reviewed
Sep 9, 2018
| @@ -261,7 +262,8 @@ static private native int createFileWithPermissionsImpl(String path, | |||
| static String getTmpDir() { | |||
| String tmpDir = getTempDirImpl(); | |||
| if (null == tmpDir) { | |||
| tmpDir = com.ibm.oti.vm.VM.getVMLangAccess().internalGetProperties().getProperty("java.io.tmpdir"); //$NON-NLS-1$ | |||
| IPC.logMessage("Could not get system temporary directory. Trying "+JAVA_IO_TMPDIR); //$NON-NLS-1$ | |||
| tmpDir = com.ibm.oti.vm.VM.getVMLangAccess().internalGetProperties().getProperty(JAVA_IO_TMPDIR); //$NON-NLS-1$ | |||
There was a problem hiding this comment.
will this default to /tmp if not set?
There was a problem hiding this comment.
The system property is set by getPlatformPropertyList() to the value of the TMPDIR environment variable (sans character set conversion, which is the present problem). If that does not resolve to a valid path, then it defaults to "/tmp".
|
jenkins test sanity plinux jdk8 |
pshipton
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the name of the temporary directory cannot be converted to UTF-16, use the
Java system property.
Fixes #2781
Signed-off-by: Peter Bain peter_bain@ca.ibm.com