Implement direct-call field resolve helpers #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
DanHeidinga
reviewed
Sep 7, 2018
runtime/codert_vm/cnathelp.cpp
Outdated
| */ | ||
| if (VM_VMHelpers::classRequiresInitialization(currentThread, fieldClass)) { | ||
| vm->internalVMFunctions->initializeClass(currentThread, fieldClass); | ||
| if (VM_VMHelpers::exceptionPending(currentThread)) { |
There was a problem hiding this comment.
Does this need to check for immediate async as well?
There was a problem hiding this comment.
Yes, I suppose it should (the resolve teardown checks it).
|
Added async check and made the jitEIP parameter implicit for the direct helpers. |
gacholio
force-pushed
the
helpers
branch
2 times, most recently
from
86cf119 to
21832a1
Compare
|
Ready for review. |
|
Jenkins line endings check |
|
I don't see the implementation of the new helpers after the conflict was resolved - ie: jitResolveStaticFieldDirect Something go wrong? |
|
Eclipse should rename "merge tool" to "deletion tool" - restored from local history (including the merged conflicting change). |
|
Jenkins test sanity plinux,xlinuxlargeheap,zlinux,aix jdk8 |
The unresolved path in the new inline field watch compilations needs to call field resolve helpers directly from the code cache. Add direct versions of the 4 helpers, with the same first 2 arguments and return value (the 3rd argument is omitted as it can be inferred from the return address like other runtime helpers). jitResolveFieldDirect jitResolveFieldSetterDirect jitResolveStaticFieldDirect jitResolveStaticFieldSetterDirect Also modified the static field reporting helpers to block if another thread is initializing the field class. [ci skip] Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
|
Merge compile error fixed. |
|
Jenkins test sanity plinux,xlinuxlargeheap,zlinux,aix jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unresolved path in the new inline field watch compilations needs to
call field resolve helpers directly from the code cache. Add direct
versions of the 4 helpers, with the same first 2 arguments and return
value (the 3rd argument is omitted as it can be inferred from the return
address like other runtime helpers).
jitResolveFieldDirect
jitResolveFieldSetterDirect
jitResolveStaticFieldDirect
jitResolveStaticFieldSetterDirect
Also modified the static field reporting helpers to block if another
thread is initializing the field class.
[ci skip]
Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com