Add support for Constant Dynamic entry in classfile writer #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengxue-IS
force-pushed
the
condyWriter
branch
from
a2e0277 to
57d3f9c
Compare
fengxue-IS
changed the title
|
@DanHeidinga can you take a look at this please? |
DanHeidinga
reviewed
Sep 14, 2018
- add constant dynamic case during constantpool analyze and writing Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
fengxue-IS
force-pushed
the
condyWriter
branch
from
57d3f9c to
9ef5381
Compare
|
looking into building test case for class writer |
|
I've opened a new issue for the test as we're broken without this and having something is better than nothing at this point. @fengxue-IS Please develop the test case under #2876 |
|
Jenkins test sanity xlinux jdk11 |
|
Jenkins test sanity win jdk10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2771
Signed-off-by: Jack Lu Jack.S.Lu@ibm.com