Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-include SCURLClassLoaderNPTests on Windows #2694

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Re-include SCURLClassLoaderNPTests on Windows #2694

merged 1 commit into from
Aug 24, 2018

Conversation

hangshao0
Copy link
Contributor

@hangshao0 hangshao0 commented Aug 23, 2018 •
edited
Loading

  1. Re-include SCURLClassLoaderNPTests on Windows on Java 10.
  2. Put sleep cmd after the class/jar files are deleted.

Fixes #2653

Signed-off-by: hangshao hangshao@ca.ibm.com

@hangshao0
Copy link
Contributor Author

hangshao0 commented Aug 23, 2018 •
edited
Loading

Reviewer: @llxia

@llxia
Copy link
Contributor

llxia commented Aug 24, 2018

Jenkins test sanity win all

@llxia
Copy link
Contributor

llxia commented Aug 24, 2018

Jenkins test sanity aix jdk10

@llxia
Copy link
Contributor

llxia commented Aug 24, 2018

Jenkins test sanity win jdk10

@llxia
Copy link
Contributor

llxia commented Aug 24, 2018

cmdLineTester_SCURLClassLoaderNPTests_1 failed on aix https://ci.eclipse.org/openj9/job/PullRequest-Sanity-JDK10-aix_ppc-64_cmprssptrs-OpenJ9/180/tapResults/

@hangshao0
Copy link
Contributor Author

I shouldn't add "2 file(s) copied" message to the required condition, they are windows messages. I will remove them.

@hangshao0
Re-include SCURLClassLoaderNPTests on Windows
49ad3e0 
1. Re-include SCURLClassLoaderNPTests on Windows on Java 10.
2. Put sleep cmd after the class/jar files are deleted.

Fixes eclipse-openj9#2653

Signed-off-by: hangshao <hangshao@ca.ibm.com>
@hangshao0
Copy link
Contributor Author

Change updated.

@llxia
Copy link
Contributor

llxia commented Aug 24, 2018

Jenkins test sanity aix jdk10

@llxia
Copy link
Contributor

llxia commented Aug 24, 2018

Jenkins test sanity win jdk10

@llxia
Copy link
Contributor

llxia commented Aug 24, 2018 •
edited
Loading

LGTM
Merge the change without waiting for travis-ci build result. Please add [ci skip] to avoid running SDK compilation for test only changes in the future.

@llxia llxia merged commit b48b6c7 into eclipse-openj9:master Aug 24, 2018
@hangshao0 hangshao0 mentioned this pull request Aug 27, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hangshao0 @llxia