Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow relocation of ClassUnload assumptions #2672

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Allow relocation of ClassUnload assumptions #2672

merged 1 commit into from
Sep 17, 2018

Conversation

dmitry-ten
Copy link
Contributor

AOT and JITaaS require assumptions to be relocated.
Add a new kind of ExternalRelocation to relocate
ClassUnload assumptions.

Signed-off-by: Dmitry Ten Dmitry.Ten@ibm.com

@dmitry-ten
Copy link
Contributor Author

This is the openj9 part of eclipse-omr/omr#2880

@dmitry-ten dmitry-ten mentioned this pull request Aug 21, 2018
Merged
@dsouzai
Copy link
Contributor

dsouzai commented Sep 13, 2018

@dmitry-ten I recommend you try and get this merged sooner rather than later; pretty soon I'm going to have to deliver my AOT changes and it's going to conflict with this pretty hard.

@dmitry-ten
Copy link
Contributor Author

How do I rerun the tests?

@dsouzai
Copy link
Contributor

dsouzai commented Sep 13, 2018

@mpirvu could you review?

mpirvu
mpirvu approved these changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
At first I didn't understand how a classUnloadAssumption with -1 for the class pointer can work at all, but Irwin pointed me to code that scans the RAT and patches all locations for which such assumptions exist.

@mpirvu
Copy link
Contributor

mpirvu commented Sep 13, 2018

Jenkins test all all jdk8

@dmitry-ten
Allow relocation of ClassUnload assumptions
0d8f5d6 
AOT and JITaaS require assumptions to be relocated.
Add a new kind of ExternalRelocation to relocate
ClassUnload assumptions.

Signed-off-by: Dmitry Ten <Dmitry.Ten@ibm.com>
@dmitry-ten
Copy link
Contributor Author

Fixed missing commas in _relocationTargetTypeToHeaderSizeMap and rebased to latest openj9.

@dmitry-ten
Copy link
Contributor Author

@mpirvu I think this can be merged now.

@mpirvu
Copy link
Contributor

mpirvu commented Sep 14, 2018

Jenkins test all all jdk8

@mstoodle mstoodle mentioned this pull request Sep 14, 2018
Merged
@mpirvu
Copy link
Contributor

mpirvu commented Sep 17, 2018

Extended tests fail for an unrelated reason (some attach test).
The sanity tests on AIX failed with this message:
17:30:34 ld: 0711-317 ERROR: Undefined symbol: _interpreterUnresolvedConstantDynamicGlue
which I don't think it's related to this work item.
@dmitry-ten could you please confirm? Thanks

@dmitry-ten
Copy link
Contributor Author

Yes, failures seem unrelated to this change.

@mpirvu mpirvu merged commit 9c43220 into eclipse-openj9:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpirvu mpirvu mpirvu approved these changes

Assignees
No one assigned
Labels
comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitry-ten @dsouzai @mpirvu @DanHeidinga