Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup related to instanceof/checkcast on X86 #2613

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

0dvictor
Copy link
Contributor

The old implementation of instanceof, checkcast, and j/l/Class.isAssignableFrom
have been deprecated, removing them.

Signed-off-by: Victor Ding dvictor@ca.ibm.com

@0dvictor
Copy link
Contributor Author

This is a follow-up of #2361, #2494, #2515, and #2551.

@andrewcraik
Copy link
Contributor

Jenkins test sanity xlinux,win

@andrewcraik
Copy link
Contributor

Jenkins test sanity win32

@andrewcraik
Copy link
Contributor

Jenkins test sanity xlinux32

@andrewcraik
Copy link
Contributor

@0dvictor seems there is a merge conflict that will need to be addressed.

The old implementation of instanceof, checkcast, and j/l/Class.isAssignableFrom
have been deprecated, removing them.

Signed-off-by: Victor Ding <dvictor@ca.ibm.com>
@0dvictor
Copy link
Contributor Author

seems there is a merge conflict that will need to be addressed.

The conflicts have been resolved.

@andrewcraik
Copy link
Contributor

Jenkins test sanity xlinux,win32

Copy link
Contributor

@andrewcraik andrewcraik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straight delete despite the mess in the diff. LGTM

@andrewcraik andrewcraik merged commit 6f3577a into eclipse-openj9:master Aug 23, 2018
@0dvictor 0dvictor deleted the cleanup branch August 24, 2018 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants