Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable atomic-free JNI #2575

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Enable atomic-free JNI #2575

merged 1 commit into from
Aug 10, 2018

Conversation

gacholio
Copy link
Contributor

@gacholio gacholio commented Aug 9, 2018

Enable the feature everywhere but ARM and OSX.

Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com

Enable the feature everywhere but ARM and OSX.

Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
@DanHeidinga
Copy link
Member

Was it intentionally turned on for the ztpf spec?

@DanHeidinga
Copy link
Member

Is there an issue that describes why this change is being made? Preferably something that covers what "Atomic-free JNI" is.

@gacholio
Copy link
Contributor Author

gacholio commented Aug 9, 2018

TPF was intentional (why not?). There is no issue.

@DanHeidinga
Copy link
Member

TPF was intentional (why not?). There is no issue.

Glad to hear. I wasn't sure this had been tested / validated on TPF

@gacholio
Copy link
Contributor Author

gacholio commented Aug 9, 2018

I don't know what level of testing TPF gets, as another team performs it. It can always be disabled if need be, though I can't imagine why it wouldn't work there.

@gacholio gacholio requested a review from DanHeidinga August 9, 2018 18:46
@DanHeidinga DanHeidinga self-assigned this Aug 9, 2018
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga
Copy link
Member

Jenkins test sanity all jdk8

@gacholio
Copy link
Contributor Author

gacholio commented Aug 9, 2018

Feature is described in issue #2576

@DanHeidinga DanHeidinga merged commit 0ded512 into eclipse-openj9:master Aug 10, 2018
@gacholio gacholio deleted the atomic branch August 10, 2018 01:53
@pshipton pshipton mentioned this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants