Bringup JDK12 #2458
Merged
Bringup JDK12 #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Jul 23, 2018
runtime/j9vm/java11vmi.c
Outdated
| @@ -1815,4 +1815,11 @@ JVM_AreNestMates(JNIEnv *env, jclass clzOne, jclass clzTwo) | |||
| assert(!"JVM_AreNestMates unimplemented"); | |||
| return JNI_FALSE; | |||
| } | |||
| #if J9VM_JCL_SE12 | |||
There was a problem hiding this comment.
Please create a new file for this change, its not appropriate for java11vmi.c
There was a problem hiding this comment.
Created a new file javanextvmi.c to contain this JDK12 specific JVM method, pls have another look.
Added a new file javanextvmi.c; Added a stub method InitializeFromArchive which is to be implemented via eclipse-openj9#2452; Added BCT_Java12MajorVersionShifted and other JDK12 related flags to support new Java version; Added JDK12 redirector library; Not added jclse12_29 yet. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
|
jenkins compile win jdk8 |
|
jenkins test sanity plinux jdk8,jdk10 |
1 similar comment
|
jenkins test sanity plinux jdk8,jdk10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringup
JDK12Added a stub method InitializeFromArchive which is to be implemented via #2452;
Added
BCT_Java12MajorVersionShiftedand otherJDK12related flags to support new Java version;Added
JDK12redirector library;Not added
jclse12_29yet.Along with ibmruntimes/openj9-openjdk-jdk#19, this PR fixes #2419, and produces following
-versionoutputReviewer: @pshipton
FYI: @DanHeidinga
Signed-off-by: Jason Feng fengj@ca.ibm.com