Generalize TR_PPCRegisterDependencyMap for all codegens #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit consists of several changes: - Migrate TR_PPCRegisterDependencyMap to the common code generator - Rename it to OMR::RegisterDependencyMap - Properly Doxygen document the new class and its APIs Unfortunately this simple code movement will not suffice due to the difference in implementation of RegisterDependencyExt between the Z codegen and the other codegens. To make this change functionional we must make additional changes: - Refactor Z RegisterDependencyExt to use OMR::RegisterDependencyExt - Replace all Z getRegister(cg) calls appropriately Signed-off-by: Filip Jeremic <fjeremic@ca.ibm.com>
fjeremic
added
comp:jit
depends:omr
|
This PR depends on eclipse-omr/omr#2737. |
|
Jenkins test sanity plinux |
0xdaryl
approved these changes
Jul 17, 2018
|
Jenkins test sanity plinux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit consists of several changes:
Unfortunately this simple code movement will not suffice due to the
difference in implementation of RegisterDependencyExt between the Z
codegen and the other codegens. To make this change functionional we
must make additional changes:
Signed-off-by: Filip Jeremic fjeremic@ca.ibm.com