Add JAVA12 preprocessor configuration #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] new configuration is not yet used Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
pshipton
reviewed
Jul 10, 2018
| <classpathentry kind="src" path="src/openj9.traceformat/share/classes"/> | ||
| <classpathentry kind="src" path="src/openj9.zosconditionhandling/share/classes"/> | ||
| <classpathentry kind="lib" path="/binaries/common/ibm/ibmjzos.jar"/> | ||
| <classpathentry kind="lib" path="/binaries/vm/third/rt-compressed.sunJava11.jar"/> |
There was a problem hiding this comment.
Did you want to change this, or wait until there is a reason?
There was a problem hiding this comment.
I don't think we should create java12.jar until there's a good reason.
|
Re the [ci skip], although its not used, I would run a build just to ensure the additions to the file didn't break it and everything else can still build. |
|
jenkins compile plinux jdk8 |
|
Ah right, we need omr to promote first. |
|
jenkins compile plinux jdk8 |
|
eclipse ci is down |
|
jenkins compile plinux jdk8 |
pshipton
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip] new configuration is not yet used