Fix getPid failure in Windows #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llxia
reviewed
Jul 9, 2018
| @@ -23,14 +23,14 @@ | |||
| --> | |||
|
|
|||
| <playlist xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../TestConfig/playlist.xsd"> | |||
| <include>path.mk</include> | |||
There was a problem hiding this comment.
can we make this file name more generic in case we need to add other settings into it?
There was a problem hiding this comment.
maybe change it to variables.mk?
|
Jenkins test sanity win jdk10 |
llxia
reviewed
Jul 9, 2018
| # [2] http://openjdk.java.net/legal/assembly-exception.html | ||
| # | ||
| # SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 OR LicenseRef-GPL-2.0 WITH Assembly-exception | ||
|
|
There was a problem hiding this comment.
Please add ############################################################################## at the end of license
Ailloviee
force-pushed
the
getPidFix_v4
branch
4 times, most recently
from
649fcbd to
7a074c4
Compare
Ailloviee
force-pushed
the
getPidFix_v4
branch
4 times, most recently
from
4fbd52d to
e94b032
Compare
llxia
reviewed
Jul 18, 2018
| -explainExcludes -xids all,$(PLATFORM),$(VARIATION) -xlist $(Q)$(TEST_RESROOT)$(D)exclude.xml$(Q) -nonZeroExitWhenError; \ | ||
| $(TEST_STATUS)</command> | ||
| <command>$(JAVA_COMMAND) $(JVM_OPTIONS) -DTESTDIR=$(Q)$(JVM_TEST_ROOT)$(GETPID_PATH)functional$(GETPID_PATH)cmdLineTests$(GETPID_PATH)runtimemxbeanTests$(Q) -DRESJAR=$(GETPID_CMDLINETESTER_RESJAR) -DEXE='$(JAVA_COMMAND) $(JVM_OPTIONS)' -DTESTSJARPATH=$(Q)$(JVM_TEST_ROOT)$(GETPID_PATH)functional$(GETPID_PATH)cmdLineTests$(GETPID_PATH)runtimemxbeanTests$(GETPID_PATH)runtimemxbeanTests.jar$(Q) -jar $(GETPID_CMDLINETESTER_JAR) -config $(Q)$(JVM_TEST_ROOT)$(GETPID_PATH)functional$(GETPID_PATH)cmdLineTests$(GETPID_PATH)runtimemxbeanTests$(GETPID_PATH)getPidTest.xml$(Q) -explainExcludes -nonZeroExitWhenError; \ | ||
| $(TEST_STATUS)</command> |
There was a problem hiding this comment.
- remove
-DRESJAR=$(GETPID_CMDLINETESTER_RESJAR)in playlist.xml - remove GETPID_CMDLINETESTER_RESJAR in variables.mk
- can we name
GETPID_PATHsome more generic? - make the following
$(JVM_TEST_ROOT)$(GETPID_PATH)functional$(GETPID_PATH)cmdLineTests$(GETPID_PATH)runtimemxbeanTests$(GETPID_PATH)to be a variable in mk
Revert changes made previously on eclipse-openj9#1638 Added test case in getPidTest.pl for getting pid in Windows. [ci skip] Signed-off-by: Charles_Zheng <Juntian.Zheng@ibm.com>
|
Jenkins test sanity win jdk10 |
|
Jenkins test sanity xlinux jdk10 |
llxia
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert changes made previously on #1638
Added test case in getPidTest.pl for getting pid in Windows.
Signed-off-by: Charles_Zheng Juntian.Zheng@ibm.com