Do not allow NODE to be null #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If NODE is set as a build parameter but is not set, the current logic will set NODE to params.node which will be null. This will produce an IllegalArgumentException 'Null value not allowed as an environment variable: NODE'. The updated logic should first look to the param, then fetch from the variable file if it is not passed. It will then throw an error if neither can be determined. [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
force-pushed
the
fix_null_node
branch
from
744d5d9 to
bcae7bd
Compare
|
Jenkins compile xlinux jdk8 |
|
adam test sanity plinux jdk8 |
1 similar comment
|
adam test sanity plinux jdk8 |
|
@vsebe please review |
|
@vsebe is on vacation until August. |
pshipton
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current logic will set NODE to params.node which
will be null. This will produce an IllegalArgumentException
'Null value not allowed as an environment variable: NODE'.
The updated logic should first look to the param,
then fetch from the variable file if it is not passed.
It will then throw an error if neither can be determined.
[skip ci]
Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com