Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime recalculate GMP kickoff headroom #2119

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

LinHu2016
Copy link
Contributor

@LinHu2016 LinHu2016 commented Jun 7, 2018

- GMP kickoff Headroom was set 1% of heap by default or 
set by user via -XXgc:tarokKickoffHeadroomRegionCount=.
- fixed size headroom count could be too big or too small for 
some special cases, then trigger the GMP too early or too late.
- new tarokKickoffHeadroomRegionRate(default 2% can be set via
-XXgc:tarokKickoffHeadroomRegionRate=nn, 0% <= nn<=50%) base on
current free memory(not include eden and survivor) for calculating
the headroom in bytes.
- update -XXgc:tarokKickoffHeadroomRegionCount= option to 
-XXgc:tarokKickoffHeadroomInBytes to allow the headroom be a 
fraction of region size.
- tarokKickoffHeadroomInBytes is initialized during 
initializeTaxationThreshold.
- tarokKickoffHeadroomInBytes is recalculating during
calculatePGCCompactionRate.

depends eclipse-omr/omr#2646

Signed-off-by: Lin Hu linhu@ca.ibm.com

@dmitripivkine dmitripivkine added comp:gc depends:omr Pull request is dependent on a corresponding change in OMR labels Jun 7, 2018
@dmitripivkine dmitripivkine requested a review from amicic June 7, 2018 17:52
@LinHu2016
Copy link
Contributor Author

there is tracepoint parameter change in eclipse-omr/omr#2646, for the pullrequest eclipse-omr/omr#2646 to pass openj9 acceptance build might need this pullrequest to merge.

@LinHu2016 LinHu2016 force-pushed the Task136262 branch 2 times, most recently from 52fc7c7 to 6d119af Compare June 12, 2018 21:44
@LinHu2016 LinHu2016 changed the title Runtime recalculate GMP kickoff headroom count Runtime recalculate GMP kickoff headroom Jun 14, 2018
	- GMP kickoff Headroom was set 1% of heap by default or 
	set by user via -XXgc:tarokKickoffHeadroomRegionCount=.
	- fixed size headroom count could be too big or too small for 
	some special cases, then trigger the GMP too early or too late.
	- new tarokKickoffHeadroomRegionRate(default 2% can be set via
	-XXgc:tarokKickoffHeadroomRegionRate=nn, 0% <= nn<=50%) base on
	current free memory(not include eden and survivor) for calculating
	the headroom in bytes.
	- update -XXgc:tarokKickoffHeadroomRegionCount= option to 
	-XXgc:tarokKickoffHeadroomInBytes to allow the headroom be a 
	fraction of region size.
	- tarokKickoffHeadroomInBytes is initialized during 
	initializeTaxationThreshold.
	- tarokKickoffHeadroomInBytes is recalculating during
	calculatePGCCompactionRate.

Signed-off-by: Lin Hu <linhu@ca.ibm.com>
@amicic
Copy link
Contributor

amicic commented Jun 19, 2018

@charliegracie
Due to dependancies, it's easiest to make a synchronized commit with eclipse-omr/omr#2646, so I'm adding you as a reviewer.

@amicic amicic requested a review from charliegracie June 19, 2018 14:29
@amicic amicic removed the request for review from charliegracie June 19, 2018 14:30
@charliegracie
Copy link
Contributor

Jenkins test sanity xlinux jdk8

@charliegracie
Copy link
Contributor

Jenkins test sanity plinux jdk8 depends eclipse-omr/omr#2646

@charliegracie
Copy link
Contributor

Sigh I can not properly testing this with PR builds now that the OMR PR has been merged :(

@charliegracie
Copy link
Contributor

Jenkins test sanity plinux jdk8 depends eclipse/omr#master

@charliegracie charliegracie merged commit 97f0fc9 into eclipse-openj9:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:gc depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants