Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Memory Stats #2101

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Print Memory Stats #2101

merged 1 commit into from
Jun 18, 2018

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Jun 6, 2018

Added the printing of JIT memory stats at shutdown if the TR_PrintPersistentMem env var is set, and every 5 minutes in the vlog if verbose={jitMemory} is set.

Depends on eclipse-omr/omr#2542

@dsouzai
Copy link
Contributor Author

dsouzai commented Jun 6, 2018

@mpirvu for your review.

@fjeremic fjeremic requested a review from mpirvu June 6, 2018 17:58
@fjeremic fjeremic assigned vijaysun-omr and unassigned mpirvu Jun 6, 2018
@@ -2711,6 +2711,9 @@ void TR::CompilationInfo::stopCompilationThreads()

if (getJProfilerThread())
fprintf(stderr, "Allocated memory for profile info = %d KB\n", getJProfilerThread()->getProfileInfoFootprint()/1024);

if (trPersistentMemory)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These statistics are probably useful only when tracking a memory leak. Also, the list of memory objects is very long.
For these two reasons I would like the printout to be enabled by another environment variable.

@dsouzai
Copy link
Contributor Author

dsouzai commented Jun 6, 2018

Changes made.

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewcraik
Copy link
Contributor

@dsouzai a rebase forward should clear up the travis failure (I hope) so we can get this tested and merged.

@dsouzai
Copy link
Contributor Author

dsouzai commented Jun 7, 2018

Because this depends on eclipse-omr/omr#2542 until that code is merged in openj9-omr, I think travis will still be broken

EDIT: It's been added to master but it's not in https://github.com/eclipse/openj9-omr/commits/openj9 still.

@fjeremic
Copy link
Contributor

fjeremic commented Jun 7, 2018

Jenkins test sanity depends eclipse-omr/omr#2542

@AdamBrousseau
Copy link
Contributor

Jenkins test sanity depends eclipse/omr#master

@dsouzai
Copy link
Contributor Author

dsouzai commented Jun 8, 2018

@vijaysun-omr This PR should be ok to merge now. I can rebase the changes if you'd like the travis build to run again, but given that sanity tests passed, it doesn't seem necessary (given how small this change is). The windows failure is unrelated and caused by something else (other PR builds are also failing on windows).

@dsouzai
Copy link
Contributor Author

dsouzai commented Jun 11, 2018

Windows issue caused by #2129

@andrewcraik andrewcraik added the depends:omr Pull request is dependent on a corresponding change in OMR label Jun 12, 2018
@dsouzai
Copy link
Contributor Author

dsouzai commented Jun 12, 2018

Rebased onto latest master for clean travis build.

@dsouzai
Copy link
Contributor Author

dsouzai commented Jun 13, 2018

Rebased onto latest master for clean travis build.

So much for that... failed because eclipse-omr/omr#2490 wasn't in openj9-omr . It looks like that change is now in openj9-omr, so let's try again..

Signed-off-by: Irwin D'Souza <dsouzai@ca.ibm.com>
@dsouzai
Copy link
Contributor Author

dsouzai commented Jun 13, 2018

@vijaysun-omr This should be good to merge now

@mpirvu mpirvu merged commit 080f427 into eclipse-openj9:master Jun 18, 2018
@dsouzai dsouzai deleted the printMemStats branch October 15, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants