Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valhalla bringup for Java 25 updates #20911

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Valhalla bringup for Java 25 updates #20911

merged 1 commit into from
Jan 13, 2025

Conversation

JasonFengJ9
Copy link
Member

@JasonFengJ9 JasonFengJ9 commented Jan 10, 2025 •
edited
Loading

Valhalla bringup for Java 25 updates

Updated -source to 25;
Updated VALUE_TYPE_CLASS_FILE_VERSION to 69;
Updated VALUE_TYPES_MAJOR_VERSION to 69.

This change is required for Valhalla extension Java 25 update

Signed-off-by: Jason Feng fengj@ca.ibm.com

@JasonFengJ9 JasonFengJ9 added comp:test project:valhalla Used to track Project Valhalla related work labels Jan 10, 2025
theresa-m
theresa-m reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@theresa-m theresa-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VALUE_TYPES_MAJOR_VERSION will also need updating.

@JasonFengJ9
Valhalla bringup for Java 25 updates
9c2f5c2 
Updated -source to 25;
Updated VALUE_TYPE_CLASS_FILE_VERSION to 69;
Updated VALUE_TYPES_MAJOR_VERSION to 69.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9 JasonFengJ9 changed the title Valhalla test bringup for Java 25 Valhalla bringup for Java 25 updates Jan 10, 2025
@JasonFengJ9
Copy link
Member Author

VALUE_TYPES_MAJOR_VERSION will also need updating.

Fixed.

@JasonFengJ9 JasonFengJ9 requested a review from theresa-m January 10, 2025 21:05
@tajila
Copy link
Contributor

tajila commented Jan 11, 2025

jenkins test sanity.functional alinux64 jdk17

@tajila
Copy link
Contributor

tajila commented Jan 11, 2025

Jenkins test sanity,extended xlinuxval jdknext

@JasonFengJ9
Copy link
Member Author

Also: org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 5619fac9-730f-4f6c-981a-6a5c431966ea
java.lang.AssertionError: Build failed because cannot find NUM_LIST in parallelList.mk file.. Expression: assert false : "Build failed because cannot find NUM_LIST in parallelList.mk file."

It seems an infra error.

This PR passed a personal build along with ibmruntimes/openj9-openjdk-jdk.valuetypes#17.

@tajila tajila merged commit 292a13b into eclipse-openj9:master Jan 13, 2025
5 of 9 checks passed
@JasonFengJ9 JasonFengJ9 deleted the valhalla25 branch January 13, 2025 15:15
@theresa-m theresa-m mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theresa-m theresa-m theresa-m approved these changes

@tajila tajila tajila approved these changes

Assignees
No one assigned
Labels
comp:test comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonFengJ9 @tajila @theresa-m