Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable all ValueTypeTestsJIT tests #20456

Merged

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Oct 31, 2024

Reenable all ValueTypeTestsJIT tests

Fixes: #19708

Fixes: eclipse-openj9#19708
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo a7ehuo added comp:jit project:valhalla Used to track Project Valhalla related work labels Oct 31, 2024
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Oct 31, 2024

@hzongaro May I ask you to review this change? Thank you!

Tested internally, these tests pass with recent changes.

@a7ehuo a7ehuo requested a review from hzongaro October 31, 2024 13:09
@hzongaro hzongaro self-assigned this Oct 31, 2024
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Member

Jenkins test sanity.functional xlinuxval,alinuxval,zlinuxval,plinuxval,winval,xmacval,aixval jdknext

@hzongaro
Copy link
Member

Windows testing looks like it failed due to an infrastructure problem.

10:42:54  ERROR: Cannot delete workspace :Unable to delete 'F:\Users\jenkins\workspace\Build_JDKnext_x86-64_windows_valhalla_Personal\openssl\NUL'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.

I'll give it one more try. . . .

Jenkins test sanity.functional winval jdknext

@hzongaro
Copy link
Member

Windows value type testing failed with the same "Unable to delete" error again. It looks like the most recent previous attempt in PR #19690 hit the same problem.

Testing was successful on all other platforms. Merging.

@hzongaro hzongaro merged commit f92435b into eclipse-openj9:master Oct 31, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tests in disabled variations of ValueTypeTestsJIT
2 participants