Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OffHeap Query in J9VM #20187

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Add OffHeap Query in J9VM #20187

merged 2 commits into from
Sep 19, 2024

Conversation

rmnattas
Copy link
Contributor

No description provided.

@rmnattas
Add OffHeap Query in J9VM
2a68c8d 
Signed-off-by: Abdulrahman Alattas <rmnattas@gmail.com>
@rmnattas rmnattas requested a review from dsouzai as a code owner September 18, 2024 19:23
@rmnattas
Copy link
Contributor Author

Testing https://hyc-runtimes-jenkins.swg-devops.com/job/Pipeline-Build-Test-Personal/23954/

@rmnattas
Copy link
Contributor Author

@zl-wang

dsouzai
dsouzai reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@dsouzai dsouzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to add similar APIs to the JITServer Frontends.

@rmnattas
Add OffHeap Query in J9ServerVM
721d444 
Signed-off-by: Abdulrahman Alattas <rmnattas@gmail.com>
@rmnattas
Copy link
Contributor Author

Added the APIs for the JITServer part, is the change correct for it @dsouzai?
Most of the code queries the ObjectModel for OffHeap, this will be the case for all in the future but for the time being this query will remain to be used.

zl-wang
zl-wang approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zl-wang
Copy link
Contributor

zl-wang commented Sep 18, 2024

jenkins test sanity aix,plinux,zlinux jdk21

@zl-wang
Copy link
Contributor

zl-wang commented Sep 19, 2024

known assertion failure caused by other PR ... unrelated to this PR. merging ...

@zl-wang zl-wang merged commit 1739d42 into eclipse-openj9:master Sep 19, 2024
7 of 9 checks passed
@dsouzai
Copy link
Contributor

dsouzai commented Sep 19, 2024 •
edited
Loading

I think you also need to update the MINOR_NUMBER in CommunicationStream.hpp whenever adding or modifying a Front End Query (or relo record, and probably some other things), but given that this is merged, maybe you can just open another PR for that.

@rmnattas rmnattas mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsouzai dsouzai dsouzai left review comments

@zl-wang zl-wang zl-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmnattas @zl-wang @dsouzai