-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Null-restricted array flattening and test fix up #19995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc4d0bd
to
ec42343
Compare
ec42343
to
195e40e
Compare
This was referenced Sep 4, 2024
4775262
to
4ec1489
Compare
4ec1489
to
d40148e
Compare
@keithc-ca I added you as reviewer for the DDR change. |
keithc-ca
requested changes
Sep 11, 2024
test/functional/Valhalla/src_qtypes/org/openj9/test/lworld/DDRBackfillLayoutTest.java
Outdated
Show resolved
Hide resolved
test/functional/cmdLineTests/valuetypeddrtests/flattenedvaluetypeddrtests.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
d40148e
to
ad8cc0d
Compare
keithc-ca
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, even if the commit message is rather brief.
Jenkins test sanity,extended zlinuxval jdknext |
Jenkins test sanity amac jdk21 |
hangshao0
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17340