Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid assertion check #1962

Merged
merged 1 commit into from
May 23, 2018
Merged

Remove invalid assertion check #1962

merged 1 commit into from
May 23, 2018

Conversation

LinHu2016
Copy link
Contributor 

The committed size of Usage could be decreasing from later
MemoryPoolMXBean.getXXXUsage() call, if GC happens between 
the calls and GC decides to contrast the memory pool.

Signed-off-by: Lin Hu linhu@ca.ibm.com

@LinHu2016
Remove invalid assertion check
f79d192 
	The committed size of Usage could be decreasing from later
	MemoryPoolMXBean.getXXXUsage() call, if GC happens between 
	the calls and GC decides to contrast the memory pool.

Signed-off-by: Lin Hu <linhu@ca.ibm.com>
@llxia
Copy link
Contributor

llxia commented May 23, 2018

  • we suspect there are other similar issue in the test, so we added comment and commented out the assertion for future reference.
  • merge the change without testing as the PR only commented out the assertion.

@llxia llxia merged commit 6f5a858 into eclipse-openj9:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinHu2016 @llxia