Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest NLS translations, updates exelib #19512

Closed
wants to merge 1 commit into from

Conversation

pshipton
Copy link
Member

No description provided.

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton pshipton requested a review from keithc-ca May 17, 2024 13:57
@@ -944,4 +944,16 @@ J9NLS_EXELIB_INTERNAL_HELP_XXNOPORTABLESHAREDCACHE.system_action=
J9NLS_EXELIB_INTERNAL_HELP_XXNOPORTABLESHAREDCACHE.user_response=
# END NON-TRANSLATABLE

J9NLS_EXELIB_INTERNAL_HELP_XXENABLESHAREORPAH=\ \ -XX: +ShareOrphans permet compartir classes sense informaci\u00f3 de cam\u00ed d'acc\u00e9s de classe/m\u00f2dul com a orfes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the space after : (in -XX: +ShareOrphans)? I don't see it in other references to -XX:... options in this file. See for example, line 934:

J9NLS_EXELIB_INTERNAL_HELP_XXPORTABLESHAREDCACHE=\ \ -XX:+PortableSharedCache ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't control the automated translations. I could fix them manually but the spaces might come back next time. I think I'll just close this PR and we can try translations again another day and hope for a better result.

Copy link
Contributor

@keithc-ca keithc-ca May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would automation add them some places, but not others or do something different on another day?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect they are constantly fiddling with translations. Much of the earlier translation was done by humans. Only recent translations, PRs I've opened, are automated. I think we could get different results by waiting a week or two. Perhaps there is a way to report a problem, but atm I don't know how to do that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other thing to note is that there is a translation cache. I don't believe it re-translates everything when translation is done, it looks for new things. Since I've submitted this translation now, perhaps it will be stuck this way, but we have seen older translated messages get updated on occasion, so I have some hope.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fix the stray, unwanted spaces, and try to report this misbehavior in hopes they won't come back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the plan for this? I still think we should remove the extra spaces (added inconsistently) and hope the automation doesn't suggest adding them back.

Copy link
Member Author

@pshipton pshipton Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does add them back, also it mangles command line options in newer messages than are translated in this PR. I need to ask on Slack about how to work around it. I do have a recent version I've updated manually, but without a work around or fix it means re-doing the fixes every time there is a new translation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone is looking into the problem with -XX: options. They aren't supposed to be modified. Hopefully afterwards they will look at the issue with --sun-misc-unsafe-memory-access.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe processing the options is fixed. However the front end for submitting translations is broken atm, it's being looked at.

@pshipton
Copy link
Member Author

pshipton commented Sep 3, 2024

Replaced by #20102

@pshipton pshipton closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants