Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused GC stats / tracing #1864

Merged
merged 1 commit into from
May 8, 2018

Conversation

charliegracie
Copy link
Contributor

@charliegracie charliegracie commented May 7, 2018

This PR completely removes the HotField Tracing stats as they cause a performance hit even when disabled.

@charliegracie charliegracie changed the title Romove unused GC stats / tracing Remove unused GC stats / tracing May 7, 2018
@charliegracie charliegracie force-pushed the gc_stats branch 2 times, most recently from fb04566 to 4ce52f0 Compare May 7, 2018 19:46
@charliegracie
Copy link
Contributor Author

Jenkins test sanity xlinux jdk8

@charliegracie
Copy link
Contributor Author

jenkins test all xlinux
jenkins compile xlinux

Testing overkill but testing out the new xLinux builds for @AdamBrousseau

@AdamBrousseau
Copy link
Contributor

jenkins test all xlinux

@AdamBrousseau
Copy link
Contributor

jenkins compile xlinux

Copy link
Contributor

@dmitripivkine dmitripivkine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

These stats are not ever used and complicated the copy-forward
code.

Signed-off-by: Charlie Gracie <charlie.gracie@gmail.com>
@AdamBrousseau
Copy link
Contributor

Jenkins test sanity xlinux jdk8

@dmitripivkine dmitripivkine self-assigned this May 8, 2018
@dmitripivkine dmitripivkine merged commit abb17de into eclipse-openj9:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants