Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullRestricted field throws NPE on null assignment in withfield #18130

Merged
merged 1 commit into from
Sep 14, 2023
Merged

NullRestricted field throws NPE on null assignment in withfield #18130

merged 1 commit into from
Sep 14, 2023

Conversation

theresa-m
Copy link
Contributor

  • withfield NPE check for NullRestricted attribute
  • rename Valhalla attribute bytecode tests for clarity

Related: #17340

@theresa-m
NullRestricted field throws NPE on null assignment in withfield
3f5b896 
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m theresa-m mentioned this pull request Sep 13, 2023
Closed
@theresa-m theresa-m requested a review from hangshao0 September 13, 2023 13:46
@hangshao0 hangshao0 added comp:vm project:valhalla Used to track Project Valhalla related work comp:test labels Sep 13, 2023
hangshao0
hangshao0 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@hangshao0 hangshao0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hangshao0
Copy link
Contributor

Jenkins test sanity xlinuxval jdknext

@hangshao0
Copy link
Contributor

Jenkins test sanity aixval jdknext

@hangshao0
Copy link
Contributor

hangshao0 commented Sep 13, 2023 •
edited
Loading

Looks like there is a Jenkins error here:

Also:   org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 0ef1adda-66dc-4330-97dc-f17667dd7d6b
java.lang.NullPointerException: Cannot invoke method containsKey() on null object
	at org.codehaus.groovy.runtime.NullObject.invokeMethod(NullObject.java:91)
	at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:47)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
	at org.codehaus.groovy.runtime.callsite.NullCallSite.call(NullCallSite.java:34)
        ...

@hangshao0
Copy link
Contributor

@AdamBrousseau ^^

@AdamBrousseau
Copy link
Contributor

I think the issue is a typo in the variable file
https://github.com/eclipse-openj9/openj9/blame/c0fab8fb3293614a9fb1c47da9252ee8b844ef31/buildenv/jenkins/variables/defaults.yml#L508
https://github.com/eclipse-openj9/openj9/blame/c0fab8fb3293614a9fb1c47da9252ee8b844ef31/buildenv/jenkins/variables/defaults.yml#L510
ppc64_aix_linux should be just ppc64_aix
If you add that change to your PR I think it should resolve the issue.

@theresa-m
Copy link
Contributor Author

Thanks Adam, I've update those lines.

@hangshao0
Copy link
Contributor

I've update those lines.

@theresa-m I have a PR for that #18136, and it is being tested.

@hangshao0
Copy link
Contributor

Link of build launched by #18130 (comment) is https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/4402/

@theresa-m
Copy link
Contributor Author

okay, I'll remove my commit.

@hangshao0 hangshao0 merged commit c53da53 into eclipse-openj9:master Sep 14, 2023
@theresa-m theresa-m deleted the nr_verification_4 branch December 6, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangshao0 hangshao0 hangshao0 approved these changes

Assignees
No one assigned
Labels
comp:test comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theresa-m @hangshao0 @AdamBrousseau